Custom Method For Block Signing Root #5704
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature Improvement
What does this PR do? Why is it needed?
When using the default ComputeSigningRoot Method we use the
generic ssz library which is very inefficient. This PR , refactors out the method
so that we can utilise any custom hashing methods.
Also add in a basic regression test so that we ensure basic compatibility.
Which issues(s) does this PR fix?
N.A
Other notes for review
N.A